Closed
Bug 763496
Opened 13 years ago
Closed 13 years ago
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: gkrizsanits, Unassigned)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
After inventing nsExpandedPrincipal in bug 734891 it can cause some issues with it that at various places of the platform there is Equals used for security checked where conceptually Subsumes should be.
One of it is in nsDocShell the bug was reported here: https://bugzilla.mozilla.org/show_bug.cgi?id=734891#c86
|
||
Comment 1•13 years ago
|
||
Which actual callsite in docshell is this?
Component: XPConnect → Document Navigation
QA Contact: xpconnect → docshell
|
Reporter | |
Comment 2•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #1)
> Which actual callsite in docshell is this?
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#7932
And thanks for putting the bug into the right place, I was wondering where to file it.
|
|
||
Comment 3•13 years ago
|
||
Ah, yes. That should totally be Subsumes.
|
|
Reporter | |
Comment 4•13 years ago
|
||
Attachment #632149 -
Flags: review?(bobbyholley+bmo)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 632149 [details] [diff] [review]
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell
To clarify, I'm not a peer here.
Attachment #632149 -
Flags: review?(bobbyholley+bmo) → review?(bzbarsky)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 632149 [details] [diff] [review]
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell
r=me
Attachment #632149 -
Flags: review?(bzbarsky) → review+
|
|
Reporter | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•